Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10060/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10060/8/be/src/service/impala-server.cc@1062 PS8, Line 1062: const PerBackendExecParams& per_backend_params = : request_state->schedule()->per_backend_exec_params(); : if (!per_backend_params.empty()) { : lock_guard<mutex> l(query_locations_lock_); : for (const auto& entry : per_backend_params) { : const TNetworkAddress& hostport = entry.first; : // Query may have been removed already by cancellation path. In particular, if : // node to fail was last sender to an exchange, the coordinator will realise and : // fail the query at the same time the failure detection path does the same : // thing. They will harmlessly race to remove the query from this map. : QueryLocations::iterator it = query_locations_.find(hostport); : if (it != query_locations_.end()) { : it->second.erase(request_state->query_id()); : } : } : } forgot to change this part, since after last patch query locations are always added even if coord has not been started. Just need to enable this part to execute if a valid schedule exists -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 8 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 11 May 2018 23:03:22 +0000 Gerrit-HasComments: Yes
