Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10314 )
Change subject: IMPALA-6970: race with decreasing scanner reservation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool.h@349 PS2, Line 349: the postcondition : /// does not hold if called concurrently with a DecreaseReservation*() call. > do you mean that the post-condition of "after which 'bytes' can be used" do Maybe just delete that sentence? It seems obvious that if you do Increase and Decrease without some external synchronization then you may not have 'bytes' at the end. Or is it trying to say else? -- To view, visit http://gerrit.cloudera.org:8080/10314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I653225c981bf674d2b2b947f3a3cb4d8f382d36b Gerrit-Change-Number: 10314 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 22:31:49 +0000 Gerrit-HasComments: Yes
