Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10314 )
Change subject: IMPALA-6970: race with decreasing scanner reservation ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool-test.cc File be/src/runtime/bufferpool/buffer-pool-test.cc: http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool-test.cc@2158 PS2, Line 2158: thread incre > nit: maybe just use 'thread' if we need only one Done http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: http://gerrit.cloudera.org:8080/#/c/10314/2/be/src/runtime/bufferpool/buffer-pool.h@349 PS2, Line 349: : bool IncreaseReservationToFit(int64_t bytes) WARN_UNUSED_RESULT; > Maybe just delete that sentence? It seems obvious that if you do Increase a Removed. Yeah it really is obvious :). -- To view, visit http://gerrit.cloudera.org:8080/10314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I653225c981bf674d2b2b947f3a3cb4d8f382d36b Gerrit-Change-Number: 10314 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 23:08:53 +0000 Gerrit-HasComments: Yes
