Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 )
Change subject: IMPALA-13051: Speed up, refactor query log tests ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/21358/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21358/5/tests/common/custom_cluster_test_suite.py@161 PS5, Line 161: # IMPALA-13051: Add faster default graceful shutdown options before processing > Can you mention the Jira? It may not be evident for the reader why this is Done http://gerrit.cloudera.org:8080/#/c/21358/5/tests/common/custom_cluster_test_suite.py@236 PS5, Line 236: > I'll probably back this change out, it's weird but doesn't cause issues rig Done http://gerrit.cloudera.org:8080/#/c/21358/5/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21358/5/tests/custom_cluster/test_query_log.py@411 PS5, Line 411: """Tests to assert that query_log_table_name works with non-default value.""" > nit: I was confused at first that this means that table table can be rename Done http://gerrit.cloudera.org:8080/#/c/21358/5/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/21358/5/tests/util/workload_management.py@93 PS5, Line 93: session_id = re.search(r'\n\s+Session ID:\s+(.*)\n', profile_text) > An idea to make these even more compact: Haven't had the bandwidth to look at this more. Seems reasonable, but also triggers a significant amount of other cleanup in this file that will take me a little while. -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 06 May 2024 22:09:17 +0000 Gerrit-HasComments: Yes
