Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 )
Change subject: IMPALA-13051: Speed up, refactor query log tests ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21358/6/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/21358/6/tests/util/workload_management.py@26 PS6, Line 26: from SystemTables.ttypes import TQueryTableColumn While these changes simplify the code quite a bit (20% or so), they also remove a couple of important assertions for total number of columns and column names. Asserting the total number of columns against a test constant prompts anyone adding a column to also update the python tests. The column name assertions are important because they ensure columns are not inadvertently renamed. Highly unlikely, but possible where a character could be deleted or added accidentally. Even though the code review should catch such a mistake, it is still best for automated checks to ensure those mistakes never cause distractions in code reviews. I like the removal of the index variable. We should remove that in favor of using the indexes from TQueryTableColumn. Then we could keep the column_val function and use it to simplify the code. -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 06 May 2024 23:02:45 +0000 Gerrit-HasComments: Yes
