Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 )
Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc@548 PS1, Line 548: FLAGS_thrift_external_rpc_max_message_size < ThriftDefaultMaxMessageSize() should this be allowed up to max value of int64_t? http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/rpc/authentication.cc@1350 PS1, Line 1350: ThriftExternalRpcMaxMessageSize() == max_message_size || : ThriftInternalRpcMaxMessageSize() == max_message_size This DCHECK is repeated in three separate places. Maybe consider making an inline function for it? http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/rpc/thrift-server.cc@288 PS1, Line 288: is_external_facing_(is_external_facing) If is_external_facing_ == false, can we DCHECK if it is legal given specified name_ or port_ ? -- To view, visit http://gerrit.cloudera.org:8080/21420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a649ef49a8a99c7bd9a1b73c37c4c621661311 Gerrit-Change-Number: 21420 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 11 May 2024 03:30:39 +0000 Gerrit-HasComments: Yes
