Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21420 )

Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift 
max message size
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc
File be/src/common/init.cc:

http://gerrit.cloudera.org:8080/#/c/21420/1/be/src/common/init.cc@548
PS1, Line 548: FLAGS_thrift_external_rpc_max_message_size < 
ThriftDefaultMaxMessageSize()
> The intention is to enforce a minimum for the rpc max message size. Someone
Is there a possibility it would parse as unsigned but then get used as signed? 
Should at least check that.

I see this is the error message added previously; I guess a little rationale 
for why would be nice. The option description mentions what happens with 0 or 
negative, but doesn't mention anything about a minimum positive value.



--
To view, visit http://gerrit.cloudera.org:8080/21420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a649ef49a8a99c7bd9a1b73c37c4c621661311
Gerrit-Change-Number: 21420
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 May 2024 19:12:33 +0000
Gerrit-HasComments: Yes

Reply via email to