Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 )
Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21420/2/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/21420/2/be/src/rpc/thrift-util.cc@94 PS2, Line 94: : // The ThriftSerializer uses the DefaultInternalTConfiguration() with the higher limit, : // because this is used on our internal Thrift structures. : ThriftSerializer::ThriftSerializer(bool compact, int initial_buffer_size) > If I'm understanding SerDeBuffer100MB, we're making sure we can serialize s I thought of increasing it to over than 2GB. But thinking again, it is probably impractical to do so in BE test. So yeah, maybe we should leave it as it is. -- To view, visit http://gerrit.cloudera.org:8080/21420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a649ef49a8a99c7bd9a1b73c37c4c621661311 Gerrit-Change-Number: 21420 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 16 May 2024 17:32:44 +0000 Gerrit-HasComments: Yes
