Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21707 )
Change subject: IMPALA-13319: Avoid duplicate exec option declaration in py.test ...................................................................... Patch Set 1: (2 comments) Looks great, a few minor questions/suggestions. http://gerrit.cloudera.org:8080/#/c/21707/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21707/1//COMMIT_MSG@9 PS1, Line 9: add_mandatory_exec_option() may replace existing query option values in Please explain that this is the current behavior. http://gerrit.cloudera.org:8080/#/c/21707/1/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/21707/1/tests/common/test_vector.py@159 PS1, Line 159: assert dimension.name.islower(), ( I'm not understanding why there is a difference in the handling of the key. Here is will fail the test due to the assert failing. In add_manadatory_exec_option, it converts the key to lowercase automatically. -- To view, visit http://gerrit.cloudera.org:8080/21707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8143e47f19090e20707cfb0a05c779f4d289f33c Gerrit-Change-Number: 21707 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 16:00:56 +0000 Gerrit-HasComments: Yes
