Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21707 )
Change subject: IMPALA-13319: Avoid duplicate exec option declaration in py.test ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21707/1/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/21707/1/tests/common/test_vector.py@159 PS1, Line 159: Add 'dimension' into 'self.dimensions' and memorize the name. > Agree, this is confusing. Patch set 2 simply assert for lowercase. Done -- To view, visit http://gerrit.cloudera.org:8080/21707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8143e47f19090e20707cfb0a05c779f4d289f33c Gerrit-Change-Number: 21707 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 18:50:15 +0000 Gerrit-HasComments: Yes
