Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21716 )
Change subject: IMPALA-13323: Remove redundant tests in test_join_queries.py ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21716/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21716/4/tests/common/impala_test_suite.py@1374 PS4, Line 1374: # TODO: enforce these warnings by changing them into pytest.fail() > Any reason we can't do this yet? Changing this to pytest.fail() immediately will require larger refactoring on some other test files. For example, from DRY_RUN log, I see these logs printed for test_nested_types.py because 'orc_schema_resolution' dimension is declared but never actually exercised. There might me more logs printed out in exhaustive exploration. I prefer to refactor the test one file at a time for easier review. -- To view, visit http://gerrit.cloudera.org:8080/21716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76efa82dad59dbb9f58a36a4a2938b5f73a382f6 Gerrit-Change-Number: 21716 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 18:41:59 +0000 Gerrit-HasComments: Yes
