Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21716 )
Change subject: IMPALA-13323: Remove redundant tests in test_join_queries.py ...................................................................... IMPALA-13323: Remove redundant tests in test_join_queries.py Before this patch, test_join_queries.py is expensive to run in exhaustive exploration because it run many test dimension permutation, but actually never exercise some of the dimensions. Those redundant tests are follows: Have mt_dop dimension, but not exercising it: - test_outer_to_inner_joins - test_single_node_nested_loop_joins Have batch_size dimension but not exercising it: - test_outer_to_inner_joins - test_single_node_nested_loop_joins - test_single_node_nested_loop_joins_exhaustive - test_semi_joins_exhaustive Have enable_outer_join_to_inner_transformation dimension but not exercising it: - All TestJoinQueries except test_outer_to_inner_joins test_miss_tuple_joins is also valid to run with much fewer test dimension because it mainly test correctness of predicate pushdown during planning. This patch reorganize test_join_queries.py into several test classes where exec option dimensions are clearly declared and correctly exercised without duplication. The reduction are follows: Before patch: 41 core tests, 526 exhaustive tests After patch: 28 core tests, 93 exhaustive tests Added validate_exec_option_dimension() in impala_test_suite.py to log WARNING if there is a dimension name matching query option name that is not also registered in 'exec_option' name. That log can be observed in log file such as logs/ee_tests/results/TEST-impala-parallel.xml. Also fix couple flake8 issues found at impala_test_suite.py Change-Id: I76efa82dad59dbb9f58a36a4a2938b5f73a382f6 Reviewed-on: http://gerrit.cloudera.org:8080/21716 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M tests/common/impala_test_suite.py M tests/query_test/test_join_queries.py 2 files changed, 200 insertions(+), 150 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I76efa82dad59dbb9f58a36a4a2938b5f73a382f6 Gerrit-Change-Number: 21716 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
