Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 )
Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate ...................................................................... Patch Set 2: Is the invariant that the tree of Exprs supposed to have unique object identity? If that's true, could we amend some of the tests to assert that? It's tempting to even make this a runtime assertion, but I don't know if we have the equivalent of DCHECK configured on the Java side. -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 02:31:38 +0000 Gerrit-HasComments: No
