Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 )
Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate ...................................................................... Patch Set 2: Tianyi, before we pursue this further let's get together for me to understand what exactly is going wrong. There should be no requirement to have different expr objects in different expr trees. Arguably, having such a guarantee would be cleaner, but I'd like to understand if there are other subtle issues lurking in the current model and whether we need a more fundamental change. -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 18:39:56 +0000 Gerrit-HasComments: No
