Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 )
Change subject: Put ASAN options in CMakeLists. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG@10 PS1, Line 10: to avoid various failures. In particular, backend tests fail Maybe I'm missing something, but why does setting this in CMake help? I don't think we run these tests through cmake-generated output, but rather through shell scripts, at least in normal automated builds. Do the environment variables set in a CMake script even carry over to processes launched by the CMake-generated build scripts? The CMake docs don't seem to be clear on the point. http://gerrit.cloudera.org:8080/#/c/10404/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10404/1/be/CMakeLists.txt@154 PS1, Line 154: set( ENV{ASAN_OPTIONS} "handle_segv=0 detect_leaks=0") The other ASAN_OPTIONS settings also have allocator_may_return_null=1 -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 16:02:20 +0000 Gerrit-HasComments: Yes
