Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 )
Change subject: Put ASAN options in CMakeLists. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG@10 PS1, Line 10: to avoid various failures. In particular, backend tests fail > Maybe I'm missing something, but why does setting this in CMake help? I don Yes, I'm confused here. My testing missed something; I'm figuring out what. It's possible that the variables percolate to "make test", but that's neither here nor there. The Jenkins job I was looking at does: $git grep ASAN_OPTIONS jenkins/build.sh: export ASAN_OPTIONS="${ASAN_OPTIONS} handle_segv=0" jenkins/build.sh: export ASAN_OPTIONS="${ASAN_OPTIONS} detect_leaks=0" Meanwhile, we always start our daemons with ASAN_OPTIONS. $git grep ASAN_OPTIONS bin/run-backend-tests.sh:export ASAN_OPTIONS="handle_segv=0 detect_leaks=0 allocator_may_return_null=1" bin/start-catalogd.sh:export ASAN_OPTIONS="handle_segv=0 detect_leaks=0 allocator_may_return_null=1" bin/start-impalad.sh:export ASAN_OPTIONS="handle_segv=0 detect_leaks=0 allocator_may_return_null=1" bin/start-statestored.sh:export ASAN_OPTIONS="handle_segv=0 detect_leaks=0 allocator_may_return_null=1" I have a few ways forward: a) Implement const char *__asan_default_options() in our C++ code and have it linked everywhere. It's tempting, and I could get rid of the environment variables. b) Add ASAN_OPTIONS to some variant of bin/run-all-tests.sh or impala-config.sh. c) In the callout to parquet-reader in tests/query_test/test_insert_parquet.py, set the environment variable explicitly. Do you have a preference? I can't decide. -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 17:58:53 +0000 Gerrit-HasComments: Yes
