Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 )
Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory ...................................................................... Patch Set 9: (2 comments) > Patch Set 9: Code-Review+2 > > (1 comment) In our downstream test environments, runtime seems unchanged. Both IMPALA_BUILD_THREADS and NUM_CONCURRENT_TESTS match prior defaults. I noticed a small impact in our pre-commit builds that I plan to address. http://gerrit.cloudera.org:8080/#/c/21200/9/bin/bootstrap_development.sh File bin/bootstrap_development.sh: http://gerrit.cloudera.org:8080/#/c/21200/9/bin/bootstrap_development.sh@70 PS9, Line 70: # export NUM_CONCURRENT_TESTS=$(nproc) It seems this setting was previously depended on for ubuntu-20.04-from-scratch. It looks like it slowed down test runs by 10-15 minutes when comparing https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/3442/ to https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/3446/. I'll add it back. I also noticed that those environments end up limited to IMPALA_BUILD_THREADS=15 rather than 16. I think that's a reasonable safety given that they link all test binaries and the number of those has been growing. http://gerrit.cloudera.org:8080/#/c/21200/9/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21200/9/bin/impala-config.sh@1226 PS9, Line 1226: echo "NUM_CONCURRENT_TESTS = $NUM_CONCURRENT_TESTS" > nit: It is probably useful to print $NUM_CONCURRENT_TESTS again either in b Ack -- To view, visit http://gerrit.cloudera.org:8080/21200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87994d0464073fe2d91bc2f7c2592c012e42de71 Gerrit-Change-Number: 21200 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 16:37:29 +0000 Gerrit-HasComments: Yes
