Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21200 )
Change subject: IMPALA-12939: Bound IMPALA_BUILD_THREADS for cgroups and memory ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21200/9/bin/bootstrap_development.sh File bin/bootstrap_development.sh: http://gerrit.cloudera.org:8080/#/c/21200/9/bin/bootstrap_development.sh@70 PS9, Line 70: # export NUM_CONCURRENT_TESTS=$(nproc) > It seems this setting was previously depended on for ubuntu-20.04-from-scra Just realized the examples I was looking at don't run EE tests, so NUM_CONCURRENT_TESTS is ignored. Looking at the actual value used Running TestExecutor with args: ['-m', 'not execute_serially and not stress', '-n', 8, '--ignore', 'comparison', '--ignore', 'custom_cluster', '--ignore', 'benchmark', '--ignore', 'util', '--ignore', 'experiments', '--ignore', 'verifiers', '--ignore', 'common', '--ignore', 'performance', '--ignore', 'beeswax', '--ignore', 'authorization', '--resultlog', '/home/ubuntu/Impala/logs/ee_tests/results/TEST-impala-parallel.log', '--junitxml', '/home/ubuntu/Impala/logs/ee_tests/results/TEST-impala-parallel.xml', '--maxfail', '0', '--exploration_strategy', 'core', '--workload_exploration_strategy', 'functional-query:core,targeted-stress:core'] I see this ends up being 8 anyway in both https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/3443/consoleFull and https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/3447/consoleFull. I don't yet understand how that happens. http://gerrit.cloudera.org:8080/#/c/21200/9/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21200/9/bin/impala-config.sh@1226 PS9, Line 1226: echo "NUM_CONCURRENT_TESTS = $NUM_CONCURRENT_TESTS" > Ack The raw TestExecutor args are printed, which includes the '-n' concurrency arg. -- To view, visit http://gerrit.cloudera.org:8080/21200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87994d0464073fe2d91bc2f7c2592c012e42de71 Gerrit-Change-Number: 21200 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 16:51:31 +0000 Gerrit-HasComments: Yes
