Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21871 )
Change subject: IMPALA-12861: Fix mixed file format listing for Iceberg tables ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21871/1/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS1: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/21871/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/21871/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@267 PS1, Line 267: nonIdentityConjuncts_, getSkippedConjuncts(), deleteScanNodeId, snapshotId_, convertFileFormats()); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/21871/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@461 PS1, Line 461: nonIdentityConjuncts_, getSkippedConjuncts(), snapshotId_, convertFileFormats()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifae900914a0d255f5a4d9b8539361247dfeaad7b Gerrit-Change-Number: 21871 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 14:07:40 +0000 Gerrit-HasComments: Yes
