Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21871 )
Change subject: IMPALA-12861: Fix mixed file format listing for Iceberg tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21871/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21871/3//COMMIT_MSG@9 PS3, Line 9: This change fixes file format information collection for Iceberg Could you also describe the problem in one sentence? http://gerrit.cloudera.org:8080/#/c/21871/3/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: http://gerrit.cloudera.org:8080/#/c/21871/3/common/fbs/IcebergObjects.fbs@20 PS3, Line 20: enum FbIcebergDataFileFormat: byte { If these are intended to be used as bit flags, it would be good to add a comment so that future modifiers can keep the invariant. -- To view, visit http://gerrit.cloudera.org:8080/21871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifae900914a0d255f5a4d9b8539361247dfeaad7b Gerrit-Change-Number: 21871 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 10:03:05 +0000 Gerrit-HasComments: Yes
