Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21871 )

Change subject: IMPALA-12861: Fix mixed file format listing for Iceberg tables
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

LGTM, thanks for fixing this!

http://gerrit.cloudera.org:8080/#/c/21871/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/21871/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@524
PS2, Line 524:
> Unfortunately, the count star optimization requires the fileFormats_ filled
Thanks for the explanation



--
To view, visit http://gerrit.cloudera.org:8080/21871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifae900914a0d255f5a4d9b8539361247dfeaad7b
Gerrit-Change-Number: 21871
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 17 Oct 2024 14:46:59 +0000
Gerrit-HasComments: Yes

Reply via email to