Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 )
Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10413/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10413/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@439 PS1, Line 439: // the block location API. > Shouldn't this check be in L424 so that synthesizeFileMd is true for EC? Ar - Files are enumerated at L430. L424 is in partition scope. - In the latest patch set only the replica is substituted with a remote address. Block offset and length are preserved. - Done http://gerrit.cloudera.org:8080/#/c/10413/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@510 PS1, Line 510: continue; > move check to L488? Files are enumerated at L502. L488 is in partition scope. http://gerrit.cloudera.org:8080/#/c/10413/1/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/10413/1/tests/common/skip.py@149 PS1, Line 149: remote_read = pytest.mark.skipif(IS_EC, reason="EC files are read remotely and " > Any more concrete reason, or are there too many to list? I haven't scrutinized all the failed tests yet. I think this list will grow later. http://gerrit.cloudera.org:8080/#/c/10413/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/10413/1/tests/query_test/test_mt_dop.py@101 PS1, Line 101: # Impala scans fewer row groups than it should with erasure coding. > fewer row groups Done -- To view, visit http://gerrit.cloudera.org:8080/10413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138738d3e28e5daa1718c05c04cd9dd146c4ff84 Gerrit-Change-Number: 10413 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Wed, 16 May 2018 20:16:05 +0000 Gerrit-HasComments: Yes
