Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 )
Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10413/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10413/3//COMMIT_MSG@12 PS3, Line 12: Mention how this patch was tested. Did you run the exhaustive build? http://gerrit.cloudera.org:8080/#/c/10413/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/10413/3/tests/common/skip.py@29 PS3, Line 29: IS_ISILON, : IS_LOCAL, : IS_HDFS, : IS_S3, : IS_ADLS, : SECONDARY_FILESYSTEM, : IS_EC This should be sorted alphabetically http://gerrit.cloudera.org:8080/#/c/10413/3/tests/common/skip.py@150 PS3, Line 150: doesn't work. "do not work" http://gerrit.cloudera.org:8080/#/c/10413/3/tests/util/filesystem_utils.py File tests/util/filesystem_utils.py: http://gerrit.cloudera.org:8080/#/c/10413/3/tests/util/filesystem_utils.py@33 PS3, Line 33: os.getenv("ERASURE_CODING") We want to check if ERASURE_CODING == true here. -- To view, visit http://gerrit.cloudera.org:8080/10413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138738d3e28e5daa1718c05c04cd9dd146c4ff84 Gerrit-Change-Number: 10413 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Fri, 18 May 2018 21:57:14 +0000 Gerrit-HasComments: Yes
