Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22062 )

Change subject: IMPALA-13487: Add profile counters for memory allocation
......................................................................


Patch Set 6:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/22062/6/be/src/exec/hdfs-columnar-scanner.cc
File be/src/exec/hdfs-columnar-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/22062/6/be/src/exec/hdfs-columnar-scanner.cc@131
PS6, Line 131:   scratch_mem_alloc_max_bytes_ = 
PROFILE_ScratchBatchMemAllocMaxBytes.Instantiate(profile);
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710
Gerrit-Change-Number: 22062
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Thu, 14 Nov 2024 22:40:27 +0000
Gerrit-HasComments: Yes

Reply via email to