Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/22062/7/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/22062/7/be/src/runtime/fragment-instance-state.cc@445 PS7, Line 445: { : SCOPED_TIMER(batch_reset_timer); : row_batch_->Reset(); : } Maybe add the timer to Reset() as optional parameter? This is a very important loop, probably it would be the best to keep remove any noise possible. http://gerrit.cloudera.org:8080/#/c/22062/7/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/22062/7/be/src/util/runtime-profile-counters.h@576 PS7, Line 576: /// Missing comment? -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2024 15:43:53 +0000 Gerrit-HasComments: Yes
