Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@11 PS1, Line 11: exec_option nor debug_action. Some others mutate vector when they shoud I'm not clear why mutating the vector is a problem. As far as I can tell pytest creates a unique copy of the vector for each method invocation. http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@24 PS1, Line 24: which is the highest version that has compatible dependecies with typo: dependencies http://gerrit.cloudera.org:8080/#/c/22301/1/infra/python/deps/py3-requirements.txt File infra/python/deps/py3-requirements.txt: http://gerrit.cloudera.org:8080/#/c/22301/1/infra/python/deps/py3-requirements.txt@34 PS1, Line 34: # Belows are needed only for dev nit: "Below" http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py@472 PS1, Line 472: """create table {} like tpch.lineitem stored as textfile""".format(tbl_name)) Would this happen automatically thanks to the vector constraint? Not sure if default table format is part of the default vector. -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 19:16:09 +0000 Gerrit-HasComments: Yes
