Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22301/4/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/22301/4/tests/common/test_vector.py@222 PS4, Line 222: values = [ImpalaTestVector.Value(val.name, val.value) for val in other_dims] On second thought, I think this is redundant. No other dims are expressed as map like EXEC_OPTION_KEY. So it is safe to keep val as it is without unpak-pack it again. -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 22:16:55 +0000 Gerrit-HasComments: Yes
