Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22301/5/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22301/5/bin/jenkins/critique-gerrit-review.py@351 PS5, Line 351: def get_catalog_compatibility_comments(base_revision, revision): There is a failure due to this: https://jenkins.impala.io/job/gerrit-auto-critic/18816/console Traceback (most recent call last): File "/var/lib/jenkins/workspace/gerrit-auto-critic/Impala/bin/jenkins/critique-gerrit-review.py", line 456, in <module> comments, get_catalog_compatibility_comments(base_revision, revision, args.dryrun)) TypeError: get_catalog_compatibility_comments() takes 2 positional arguments but 3 were given BTW, we need the job to automatically post this.. -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2025 00:43:44 +0000 Gerrit-HasComments: Yes
