Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 )
Change subject: IMPALA-7055: fix race with DML errors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10491/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10491/1//COMMIT_MSG@12 PS1, Line 12: Updating backend_exec_complete_barrier_ isn't actually necessary : when handling error BTW, that's kind of true, except that if we've already seen an error then we won't transition. So, handling an error here doesn't guarantee the notify with happen. -- To view, visit http://gerrit.cloudera.org:8080/10491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafd0b342e77a065be7cc28fa8c8a9df445622c2 Gerrit-Change-Number: 10491 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 00:04:26 +0000 Gerrit-HasComments: Yes
