Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10491 )
Change subject: IMPALA-7055: fix race with DML errors ...................................................................... Patch Set 1: (2 comments) Maybe take another look to make sure that my change was what you intended http://gerrit.cloudera.org:8080/#/c/10491/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10491/1//COMMIT_MSG@12 PS1, Line 12: Updating backend_exec_complete_barrier_ isn't actually necessary : when handling error > BTW, that's kind of true, except that if we've already seen an error then w Yeah you're right, it is necessary if the state was already RETURNED_RESULTS and we got an error after that transition. http://gerrit.cloudera.org:8080/#/c/10491/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10491/1/be/src/runtime/coordinator.cc@688 PS1, Line 688: if (VLOG_QUERY_IS_ON && pending_backends >= 0) { : VLOG_QUERY << "Backend completed:" : << " host=" << TNetworkAddressToString(backend_state->impalad_address()) : << " remaining=" << pending_backends : << " query_id=" << PrintId(query_id()); : BackendState::LogFirstInProgress(backend_states_); : } > I think I messed this up because I wanted this log to print before the logg Yeah that makes sense actually, put it back up the top. -- To view, visit http://gerrit.cloudera.org:8080/10491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafd0b342e77a065be7cc28fa8c8a9df445622c2 Gerrit-Change-Number: 10491 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 00:28:48 +0000 Gerrit-HasComments: Yes
