Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 29: (9 comments) http://gerrit.cloudera.org:8080/#/c/21803/29/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21803/29/be/src/service/impala-server.cc@1775 PS29, Line 1775: if (vlog) VLOG(1) << err.GetDetail(); Why have this if statement? To me, it makes more sense to return the error and let the function callers decide whether or not to log that error. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Canceller.java@54 PS29, Line 54: TUniqueId queryId I recommend making this a java.util.Optional<TUniqueId> instead of using null as a way of indicating state. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Canceller.java@54 PS29, Line 54: push The name "put" is typically associated with a stack data type. I suggest renaming this function to "put" or "add" to better reflect what it does. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Canceller.java@63 PS29, Line 63: pop The name "pop" is typically associated with a stack data type. I suggest renaming this function to "remove" or "delete" to better reflect what it does. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Canceller.java@63 PS29, Line 63: TUniqueId queryId I recommend making this a java.util.Optional<TUniqueId> instead of using null as a way of indicating state. http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/29/fe/src/main/java/org/apache/impala/service/Frontend.java@2041 PS29, Line 2041: public static void cancelExecRequest(TUniqueId queryId) { At first I didn't see the need for this function but then realized its used by the backend. Can you please add a comment explaining its use? http://gerrit.cloudera.org:8080/#/c/21803/29/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/29/tests/custom_cluster/test_web_pages.py@553 PS29, Line 553: @CustomClusterTestSuite.with_args( Should there be a test that runs a query that spawns child queries to ensure cancelling works properly in that situation? http://gerrit.cloudera.org:8080/#/c/21803/29/tests/custom_cluster/test_web_pages.py@632 PS29, Line 632: def test_query_cancel_piggyback(self): What about adding a test that does the opposite of this one where it cancels the first slow running query and asserts the second two queries complete successfully. http://gerrit.cloudera.org:8080/#/c/21803/29/tests/util/web_pages_util.py File tests/util/web_pages_util.py: http://gerrit.cloudera.org:8080/#/c/21803/29/tests/util/web_pages_util.py@81 PS29, Line 81: _ > Planning to clean this up when https://gerrit.cloudera.org/c/22452 is merge Note: 22452 is now merged -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 29 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 22:41:09 +0000 Gerrit-HasComments: Yes
