Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/32/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/32/fe/src/main/java/org/apache/impala/service/Canceller.java@83 PS32, Line 83: Thread queryThread = queryThreads_.get(queryId); > Maybe this should be queryThreads_.remove(queryId) so it will never race ag Or maybe, queryThreads_.get(queryId) first, synchronized over the returned thread, and only call queryThreads_.remove(queryId) after either Canceller.remove() / Canceller.cancel() complete. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 32 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 23:42:43 +0000 Gerrit-HasComments: Yes
