Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor webUI scripts to use ES6 syntax ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl@55 PS10, Line 55: #fragment_metrics_resize_bar, #fragment_metrics_resize_bar { Why was this renamed? It seems redundant now. http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl@290 PS10, Line 290: const export_style = document.getElementById("page_export_css"); Where is this variable used? -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 19:22:46 +0000 Gerrit-HasComments: Yes
