Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor webUI scripts to use ES6 syntax ...................................................................... Patch Set 11: (3 comments) Thanks for noticing. There were some refactors after PS-5, where 'host_utilization' was replaced by 'fragment_metrics'. > JS tests handled them and helped identify the wrong changes. The JS script problems were exposed by JS_TESTs. But, the .tmpl was overlooked. Sorry I missed. http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl@55 PS10, Line 55: #host_utilization_resize_bar, #fragment_metrics_resize_bar { > Why was this renamed? It seems redundant now. Done http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl@290 PS10, Line 290: const export_style = document.getElementById("page_export_css"); Done. IMPALA-13473's rules would really be useful to point such mistakes from now on. This rule was also added to config. > - Disallow unused variables http://gerrit.cloudera.org:8080/#/c/21851/10/www/query_timeline.tmpl@299 PS10, Line 299: `<style>${export_style.innerHTML} ${chart_export_style}</style>`, > This still seems to use the page_export_css global rather than the export_s Done. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 11 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 11:32:33 +0000 Gerrit-HasComments: Yes
