Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )
Change subject: IMPALA-13804: Use redacted statement in live table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json File testdata/workload_mgmt/redaction.json: http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json@11 PS3, Line 11: } : Is this JSON misaligned? http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py@37 PS3, Line 37: from tests.util.workload_management import (assert_query, WM_DB, QUERY_TBL_LOG, : redaction_rules_file) nit: Consider breaking line after open parenthesis. from tests.util.workload_management import ( assert_query, WM_DB, QUERY_TBL_LOG, redaction_rules_file) http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py@712 PS3, Line 712: return "{}/testdata/workload_mgmt/redaction.json".format(os.environ["IMPALA_HOME"]) Please add comment describing what this JSON file is trying to redact. -- To view, visit http://gerrit.cloudera.org:8080/22556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e Gerrit-Change-Number: 22556 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 23:25:57 +0000 Gerrit-HasComments: Yes
