Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )
Change subject: IMPALA-13804: Use redacted statement in live table ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py@714 PS6, Line 714: os.environ["IMPALA_HOME"] > nit: There is an IMPALA_HOME in environ.py I didn't know about that constant. I don't see where it's used though. I see lots of os.environ['IMPALA_HOME'] though, thus I think we should stick with the established style and not use the IMPALA_HOME constant. -- To view, visit http://gerrit.cloudera.org:8080/22556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e Gerrit-Change-Number: 22556 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 00:03:00 +0000 Gerrit-HasComments: Yes
