Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22566 )
Change subject: IMPALA-13816: Reduce test_queue_reasons_slots ...................................................................... Patch Set 2: (3 comments) Thank you for catching these mistakes! http://gerrit.cloudera.org:8080/#/c/22566/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22566/1//COMMIT_MSG@7 PS1, Line 7: I > Nit: missing "I": "IMPALA". Done http://gerrit.cloudera.org:8080/#/c/22566/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22566/1/tests/custom_cluster/test_admission_controller.py@1073 PS1, Line 1073: part_be > Could use 'part_begin' here. Done http://gerrit.cloudera.org:8080/#/c/22566/1/tests/custom_cluster/test_admission_controller.py@1085 PS1, Line 1085: m > Could use the 'mt_dop' variable from L1070. Done -- To view, visit http://gerrit.cloudera.org:8080/22566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d6d68d381d22c599d4c5cdc78cc997ddef749b Gerrit-Change-Number: 22566 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 03 Mar 2025 13:17:31 +0000 Gerrit-HasComments: Yes
