Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22566 )
Change subject: IMPALA-13816: Reduce test_queue_reasons_slots ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22566/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22566/2/tests/custom_cluster/test_admission_controller.py@1074 PS2, Line 1074: # This query runs for roughly 2s in normal build. > Is this dominated by table loading? Is it similar in release and debug buil I think this query was dominated by the scan volume, such that 5 serial run of the same queries does not finish within 60s in ASAN build. Thus, I reduced it by assigning 1 partition per scan instance. In my local ASAN and DEBUG build, the new query run roughly the same duration. self._execute_and_collect_profiles() submit the same query 3 times simultaneously using execute_async. As long as the admission_control_slots == mt_dop, we should still see the queueing effect (ie., the assertions below still hold), even if the test query becomes really fast. -- To view, visit http://gerrit.cloudera.org:8080/22566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d6d68d381d22c599d4c5cdc78cc997ddef749b Gerrit-Change-Number: 22566 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 03 Mar 2025 15:41:13 +0000 Gerrit-HasComments: Yes
