Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22569 )
Change subject: WIP IMPALA-13790: Fix test_wildcard_san_ssl / test_wildcard_ssl ...................................................................... Patch Set 4: Code-Review+1 (5 comments) A few nits and typos, really. And thanks a lot for adding the detailed OpenSSL parameters to the certificate creation details! http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@13 PS4, Line 13: idenfified nit: identified http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@16 PS4, Line 16: it nit: them http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@21 PS4, Line 21: Tested on: Could you please check this on Ubuntu 22.04 as well? We do have jobs on that platform as well (on upstream Jenkins). Thanks! http://gerrit.cloudera.org:8080/#/c/22569/4/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/22569/4/bin/bootstrap_system.sh@488 PS4, Line 488: certifacates nit: certificates http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@84 PS4, Line 84: SSL_ARGS = ("--ssl_client_ca_certificate=%s/server-cert.pem " I think the whole argument block would look nicer if the string manipulation syntax update were added to this statement as well; they are logically the same block. I don't feel strongly about this, but if you made the effort to change the preceding two statements (and for a good reason, no arguments about it), I think this block could also do with this improvement, just to keep this stanza consistent. -- To view, visit http://gerrit.cloudera.org:8080/22569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedf682d06bdb6f8f68a5f77e41175e895b77ca9 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Tue, 04 Mar 2025 16:46:59 +0000 Gerrit-HasComments: Yes
