Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22569 )
Change subject: WIP IMPALA-13790: Fix test_wildcard_san_ssl / test_wildcard_ssl ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@13 PS4, Line 13: identified > nit: identified Done http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@16 PS4, Line 16: th > nit: them Done http://gerrit.cloudera.org:8080/#/c/22569/4//COMMIT_MSG@21 PS4, Line 21: Tested on: > Could you please check this on Ubuntu 22.04 as well? We do have jobs on tha will update the commit message when I have test results http://gerrit.cloudera.org:8080/#/c/22569/4/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/22569/4/bin/bootstrap_system.sh@488 PS4, Line 488: certificates > nit: certificates Done http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@74 PS4, Line 74: ).format(CERT_DIR, "ip4.impala.test") > nit: format after close parenthesis, here and below. Done http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@84 PS4, Line 84: SSL_ARGS = ("--ssl_client_ca_certificate={0}/server-cert.pem > I think the whole argument block would look nicer if the string manipulatio Done http://gerrit.cloudera.org:8080/#/c/22569/4/tests/custom_cluster/test_client_ssl.py@258 PS4, Line 258: python3_10_version_re = re.compile(r"using > nit: break line after colon, here and others above. Done -- To view, visit http://gerrit.cloudera.org:8080/22569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedf682d06bdb6f8f68a5f77e41175e895b77ca9 Gerrit-Change-Number: 22569 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 04 Mar 2025 21:26:53 +0000 Gerrit-HasComments: Yes
