Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22583/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/bin/impala-config.sh@302 PS1, Line 302: # The following environment variables allow a specific base image to be specified directly, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22583/1/bin/impala-config.sh@306 PS1, Line 306: export IMPALA_CUSTOM_DOCKER_BASE=${IMPALA_CUSTOM_DOCKER_BASE:-"cgr.dev/chainguard/wolfi-base:latest"} line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_bash_if_needed.sh File docker/install_bash_if_needed.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_bash_if_needed.sh@55 PS1, Line 55: echo "Only ChainGuard/Wolfi, Ubuntu, or Redhat (or derivative) base images are supported." line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh@135 PS1, Line 135: echo "Only Ubuntu and Redhat-based distributions, or Chainguard/Wolfi base images are supported." line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 22:48:53 +0000 Gerrit-HasComments: Yes
