Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/22583/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22583/1//COMMIT_MSG@33 PS1, Line 33: - USE_CUSTOM_IMPALA_BASE_IMAGE (boolean): : If set to 'true', triggers the use of the custom image. : When set to 'false' or left unspecified, the Docker base image is : selected by the existing logic of matching the build platform's : operating system. : - IMPALA_CUSTOM_DOCKER_BASE (string): specifies the URI of the bas > Thanks for spotting; these were the original names of the environment varia Done http://gerrit.cloudera.org:8080/#/c/22583/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/bin/impala-config.sh@302 PS1, Line 302: # The following environment variables allow a specific base image to be specified > Ack Done http://gerrit.cloudera.org:8080/#/c/22583/1/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/daemon_entrypoint.sh@176 PS1, Line 176: else : echo "ERROR: en_US.utf8 locale is not present." > Ack Done http://gerrit.cloudera.org:8080/#/c/22583/1/docker/daemon_entrypoint.sh@194 PS1, Line 194: exec "$@" > Hmmm..... great catch; might be an earlier copy-paste (or maybe rebase/merg Done http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_base/Dockerfile File docker/impala_base/Dockerfile: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_base/Dockerfile@33 PS1, Line 33: ADD --chown=root:root --chmod=755 helper/install_os_packages.sh /root/ : > Ack Done http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_profile_tool/Dockerfile File docker/impala_profile_tool/Dockerfile: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_profile_tool/Dockerfile@34 PS1, Line 34: ADD --chown=root:root --chmod=755 helper/install_os_packages.sh /root/ : > Ack, Done http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh@128 PS1, Line 128: fi : > I've decided to remove the extra check for apk: better to be conservative o Done http://gerrit.cloudera.org:8080/#/c/22583/2/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/22583/2/docker/install_os_packages.sh@132 PS2, Line 132: echo "Only Ubuntu and Redhat-based distributions, or Chainguard/Wolfi base images are supported." forgot to shorten this -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Fri, 07 Mar 2025 00:07:10 +0000 Gerrit-HasComments: Yes
