Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22600 )

Change subject: WIP IMPALA-13813: OAuth Avoid key verification on every rpc call
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22600/2/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:

http://gerrit.cloudera.org:8080/#/c/22600/2/be/src/rpc/authentication.cc@862
PS2, Line 862:       Substitute("Set-Cookie: $0", GenerateCookie(username, 
hash, nullptr, &expiry_time_interval)));
line too long (100 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3e5d9cf8bdb99920611b06571515e05e15164e
Gerrit-Change-Number: 22600
Gerrit-PatchSet: 2
Gerrit-Owner: gaurav singh <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 12 Mar 2025 21:46:37 +0000
Gerrit-HasComments: Yes

Reply via email to