Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22600 )
Change subject: WIP IMPALA-13813: OAuth Avoid key verification on every rpc call ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22600/3/be/src/rpc/authentication-util.h File be/src/rpc/authentication-util.h: http://gerrit.cloudera.org:8080/#/c/22600/3/be/src/rpc/authentication-util.h@36 PS3, Line 36: = nullptr Might be able to use FLAGS_max_cookie_lifetime_s as the default value instead of nullptr. If that is not possible, then set the default value to -1 and in the .cc file, use FLAGS_max_cookie_lifetime_s when the value is less than 0. Either way, avoid the pointer since the value of cookie_lifetime_s is not used be the callers after the function returns. http://gerrit.cloudera.org:8080/#/c/22600/3/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/22600/3/be/src/rpc/authentication.cc@811 PS3, Line 811: LOG(ERROR) << "Error extracting expiry time from OAuth token received from: " Include the username in this log message to help debugging. http://gerrit.cloudera.org:8080/#/c/22600/3/be/src/rpc/authentication.cc@874 PS3, Line 874: &expiry_time_interval))); Might as well move this duplicate code into somewhere it can be called from both JWTTokenAuth and OAuthTokenAuth -- To view, visit http://gerrit.cloudera.org:8080/22600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e3e5d9cf8bdb99920611b06571515e05e15164e Gerrit-Change-Number: 22600 Gerrit-PatchSet: 3 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 21:43:23 +0000 Gerrit-HasComments: Yes
