Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22334
to look at the new patch set (#4).
Change subject: IMPALA-13904: Run parser junit tests through Calcite Planner
......................................................................
IMPALA-13904: Run parser junit tests through Calcite Planner
All the parser tests will now be run through the Calcite Planner parser.
The CalciteParserFixture class handles the Calcite parsing.
The queries that parse with the original planner need to be properly
handled when they do not parse in the Calcite planner, and vice versa.
There are various mechanism as to how this is handled:
KNOWN_GENERAL_SYNTAX_FAILURES: contains certain phrases that are known
not to work in Calcite
PARSES_OK_FAILURES: Specific SQL statements that pass in the original
planner but fail in Calcite
PARSES_ERROR_FAILURES: Specific SQL statements that pass in the Calcite
planner but fail in the original planner
Specific tests that do not run: Some tests cannot be run yet in Calcite
do to the nature of what they are testing. An example is Test*Hints which
look at the hints that are parsed, and Calcite does not handle hints yet
Various operators: Certain operators still need to be supported in Calcite.
The parser test framework has methods that specify the operators. Calcite
overrides these methods and only tests the ones that are supported. An
example of this is getOperatorsToTest() which contains certain operators
that are not yet supported in Calcite
Change-Id: I30a2b3422fa4c408dc6766d3ccef0c05f2ecc093
---
A fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java
M fe/src/test/java/org/apache/impala/analysis/CupParserFixture.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/common/ParserFixture.java
M java/calcite-planner/pom.xml
5 files changed, 623 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/22334/4
--
To view, visit http://gerrit.cloudera.org:8080/22334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30a2b3422fa4c408dc6766d3ccef0c05f2ecc093
Gerrit-Change-Number: 22334
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
