Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22334 )
Change subject: IMPALA-13904: Run parser junit tests through Calcite Planner ...................................................................... Patch Set 4: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22334/4/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java File fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java: http://gerrit.cloudera.org:8080/#/c/22334/4/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java@254 PS4, Line 254: throw new RuntimeException("Statment did not parse in Calcite but parsed in Impala: " + stmt); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22334/4/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java@463 PS4, Line 463: private ParsedStatement createParsedStatement(TQueryCtx queryCtx) throws ImpalaException { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30a2b3422fa4c408dc6766d3ccef0c05f2ecc093 Gerrit-Change-Number: 22334 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 26 Mar 2025 17:48:00 +0000 Gerrit-HasComments: Yes
