Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21175 )
Change subject: IMPALA-12829: Skip processing transaction events if the table is HMS sync disabled. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21175/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21175/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4516 PS7, Line 4516: String tblFlagVal = tbl.getParameters() : .get(MetastoreEventPropertyKey.DISABLE_EVENT_HMS_SYNC.getKey()); : if (tblFlagVal != null ) { : return Boolean.valueOf(tblFlagVal.trim()); : } > could use public static Boolean getHmsSyncProperty() for this - or even bet getHmsSyncProperty() is a method of MetastoreTableEvent class and CommitTXN is a MetastoreEvent class, so this is not possible. Also, isEventProcessingDisabled() cannot be implemented in CommitTXN class because we won't have dbNames/tableNames until the process() method. -- To view, visit http://gerrit.cloudera.org:8080/21175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0ecb3b756755bc04c66a538a9ae6b88011a019 Gerrit-Change-Number: 21175 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 24 Apr 2025 23:04:19 +0000 Gerrit-HasComments: Yes
