Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21175 )

Change subject: IMPALA-12829: Skip processing transaction events if the table 
is HMS sync disabled.
......................................................................


Patch Set 10:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/21175/10/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/21175/10/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@995
PS10, Line 995:         int numPartsRefreshed = 
catalogOpExecutor.addCommittedWriteIdsAndReloadPartitionsIfExist(eventId, 
dbName,
line too long (113 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0ecb3b756755bc04c66a538a9ae6b88011a019
Gerrit-Change-Number: 21175
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Wed, 07 May 2025 23:36:13 +0000
Gerrit-HasComments: Yes

Reply via email to