Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22600 )
Change subject: IMPALA-13813: OAuth/JWT Avoid key verification on every rpc call ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py@79 PS9, Line 79: get_metric_values No need to use get_metrics_values since only 1 metric is being retrieved, can use get_metric_value instead. http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py@91 PS9, Line 91: Success Nit: the word "Count" would be more descriptive. http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py File tests/custom_cluster/test_shell_oauth_auth.py: http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py@78 PS9, Line 78: get_metric_values No need to use get_metrics_values since only 1 metric is being retrieved, can use get_metric_value instead. http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py@90 PS9, Line 90: Success Nit: the word "Count" would be more descriptive. -- To view, visit http://gerrit.cloudera.org:8080/22600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e3e5d9cf8bdb99920611b06571515e05e15164e Gerrit-Change-Number: 22600 Gerrit-PatchSet: 9 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 30 Apr 2025 19:38:15 +0000 Gerrit-HasComments: Yes
