gaurav singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22600 )

Change subject: IMPALA-13813: OAuth/JWT Avoid key verification on every rpc call
......................................................................


Patch Set 10:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py
File tests/custom_cluster/test_shell_jwt_auth.py:

http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py@79
PS9, Line 79: get_metric_value(
> No need to use get_metrics_values since only 1 metric is being retrieved, c
Done


http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_jwt_auth.py@91
PS9, Line 91: nt"
> Nit: the word "Count" would be more descriptive.
Done


http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py
File tests/custom_cluster/test_shell_oauth_auth.py:

http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py@78
PS9, Line 78: get_metric_value(
> No need to use get_metrics_values since only 1 metric is being retrieved, c
Done


http://gerrit.cloudera.org:8080/#/c/22600/9/tests/custom_cluster/test_shell_oauth_auth.py@90
PS9, Line 90: nt"
> Nit: the word "Count" would be more descriptive.
Done



--
To view, visit http://gerrit.cloudera.org:8080/22600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3e5d9cf8bdb99920611b06571515e05e15164e
Gerrit-Change-Number: 22600
Gerrit-PatchSet: 10
Gerrit-Owner: gaurav singh <gsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Apr 2025 20:39:01 +0000
Gerrit-HasComments: Yes

Reply via email to